Skip to content

Document logout success_handler configuration #10631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

simshaun
Copy link
Contributor

@simshaun simshaun commented Nov 4, 2018

The Security docs tell how to control what happens after logging out, but the security configuration reference is missing documentation on the logout success_handler.

Partially related to #4258

Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simshaun thanks for this contribution! You did it great, except for a tiny detail. The length of the line below the success_handler title must be of the same length as the title. I know it's picky, but it's a requirement of the format we use to write the docs. Thanks!

@simshaun
Copy link
Contributor Author

simshaun commented Nov 5, 2018

Sorry about that. Updated!

@javiereguiluz javiereguiluz added this to the 2.8 milestone Nov 6, 2018
@javiereguiluz
Copy link
Member

Nice contribution! Thank you Shaun.

javiereguiluz added a commit that referenced this pull request Nov 6, 2018
This PR was squashed before being merged into the 2.8 branch (closes #10631).

Discussion
----------

Document logout success_handler configuration

The [Security docs](https://symfony.com/doc/current/security.html#logging-out) tell how to control what happens after logging out, but the security configuration reference is missing documentation on the logout success_handler.

_Partially_ related to #4258

Commits
-------

b93452a Document logout success_handler configuration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants