Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the PHP built-in server with the Symfony CLI one #11567

Merged
merged 1 commit into from
May 17, 2019

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented May 13, 2019

I think it makes sense as the built-in web server has many limitations, but also because it seems to not work on PHP 7.3 (see symfony/symfony#30471).

@fabpot fabpot force-pushed the php-built-in-web-server-removal branch from 06b4163 to 473e072 Compare May 13, 2019 06:33
@Simperfit
Copy link
Contributor

see symfony/symfony#31217 too

@OskarStark
Copy link
Contributor

I am not sure that replacing the php built in webserver is the right decision. 👍 for promoting the Symfony Local Web Server more, but maybe we should show both options like we do for the different config formats (YAML, XML, PHP).

Ok there is a bug right now which prevents using PHP 7.3, but this should be fixed shortly (hopefully) and other libs could have bugs, too. Removing it completely should not be the first step.

Another point to me is, that Symfony is open (recommend only a Symfony tool for this could lead to the meaning that it gets more and more "closed") and usable with the PHP built in webserver and works for a lot of people using PHP < 7.3.

I would not hesitate to merge this PR and go this direction, but would like to hear some other comments first.

@javiereguiluz what do you think of showing both options side by side?

@OskarStark OskarStark added this to the 3.4 milestone May 13, 2019
Copy link
Contributor

@Pierstoval Pierstoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a note about the server:start --daemon option that launches the server in the background?
It works for any OS, and it helps not having 10 terminal tabs/windows opened when working.

@wouterj
Copy link
Member

wouterj commented May 17, 2019

Whenever you show something side by side in the docs, you have to explain when to choose one over the other. I can't think of a reason to show the build-in PHP server?

I'm 👍 on using the Symfony local server here, it's designed specially for the cases where you're developing a Symfony app locally and don't have any nginx/apache installed.

@javiereguiluz
Copy link
Member

Thanks.

@javiereguiluz javiereguiluz merged commit 473e072 into symfony:3.4 May 17, 2019
javiereguiluz added a commit that referenced this pull request May 17, 2019
… (fabpot)

This PR was merged into the 3.4 branch.

Discussion
----------

Replace the PHP built-in server with the Symfony CLI one

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

I think it makes sense as the built-in web server has many limitations, but also because it seems to not work on PHP 7.3 (see symfony/symfony#30471).

Commits
-------

473e072 replaced PHP built-in server with the Symfony CLI one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants