[Security] query string can't be used in security.access_control > path #12605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexislefebvre
changed the title
wouterj
approved these changes
Nov 8, 2019
|
@alexislefebvre I like this proposal ... but I think it's too hidden in the new text. I'd create a separate phrase (or maybe a note?) clearly saying that query parameters are ignored for access_control regexp matches. |
wouterj
added a commit
that referenced
this pull request
Nov 9, 2019
…_control > path (alexislefebvre)
This PR was merged into the 3.4 branch.
Discussion
----------
[Security] query string can't be used in security.access_control > path
Goal: explain that GET parameters are ignored, so the following rule won't work:
```
- { path: ^/foo/bar\?foobar=[0-9]+, roles: [ ROLE_USER ], methods: [ GET ] }
```
Source: https://stackoverflow.com/questions/46600752/symfony-access-control-regex-with-get-parameter
Commits
-------
2877f9b access_control.rst: query string is ignored
wouterj
added a commit
that referenced
this pull request
Nov 9, 2019
wouterj
added a commit
that referenced
this pull request
Nov 9, 2019
* 3.4: [#12605] Transformed GET parameter notice to caution access_control.rst: query string is ignored
wouterj
added a commit
that referenced
this pull request
Nov 9, 2019
* 4.3: [#12605] Transformed GET parameter notice to caution access_control.rst: query string is ignored [mercure] compatibility with v0.8 Update doctrine.rst
wouterj
added a commit
that referenced
this pull request
Nov 9, 2019
* 4.4: [#12605] Transformed GET parameter notice to caution access_control.rst: query string is ignored [Console] Update some method names [mercure] compatibility with v0.8 Update doctrine.rst
|
Thanks @alexislefebvre! I've applied Javier's suggestion of moving this into a more explicit caution in 35b812c |
|
Thanks a lot @wouterj! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: explain that GET parameters are ignored, so the following rule won't work:
Source: https://stackoverflow.com/questions/46600752/symfony-access-control-regex-with-get-parameter