Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Update access_control.rst #14816

Merged
merged 1 commit into from
Jan 12, 2021
Merged

[Security] Update access_control.rst #14816

merged 1 commit into from
Jan 12, 2021

Conversation

BooleanType
Copy link
Contributor

@BooleanType BooleanType commented Jan 10, 2021 •
edited by OskarStark
Loading

IMHO, rule 1 should be applied instead of rule 2, because URI and IP match is enough for rule 1.

@xabbuh
Copy link
Member

xabbuh commented Jan 11, 2021

I think a better solution would be to reorder the rules instead.

@xabbuh xabbuh added this to the 4.4 milestone Jan 11, 2021
@BooleanType
Copy link
Contributor Author

I think a better solution would be to reorder the rules instead.

Thought about it too :) Done.

@carsonbot carsonbot changed the title Update access_control.rst [Security] Update access_control.rst Jan 12, 2021
xabbuh
xabbuh approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great apart from my little comment!

security/access_control.rst Outdated Show resolved Hide resolved
@OskarStark OskarStark changed the base branch from 5.2 to 4.4 January 12, 2021 08:20
@OskarStark OskarStark requested a review from HeahDude as a code owner January 12, 2021 08:20
@OskarStark
Copy link
Contributor

Thank you @BooleanType.

@OskarStark OskarStark merged commit f50119c into symfony:4.4 Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

@HeahDude HeahDude Awaiting requested review from HeahDude

Assignees
No one assigned
Labels
Security Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@BooleanType @xabbuh @OskarStark @carsonbot