[Mailer] max_per_second option configurable via DSN
#16800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please target |
|
According to symfony/symfony#46315 (comment) the patch should be merged into 6.1 branch. |
|
Sorry I misread the PR header, you introduce the ability to set it via DSN in 6.1, but as its freezes, it should target 6.2 👍 |
OskarStark
approved these changes
May 17, 2022
carsonbot
added
Status: Reviewed
and removed
Status: Needs Work
Status: Needs Review
labels
OskarStark
changed the title
max_per_second option configurable via DSN
carsonbot
changed the title
max_per_second option configurable via DSNmax_per_second option configurable via DSN
|
Please rebase on |
|
Rebased onto 6.2 |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Jul 20, 2022
…(gassan) This PR was merged into the 6.2 branch. Discussion ---------- [Mailer] `max_per_second` option configurable via DSN | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | symfony/symfony-docs#16800 This option is available since 5.1, but it was impossible to configure it by dsn. Commits ------- a377f2e made max_per_second option configurable by dsn
symfony-splitter
pushed a commit
to symfony/mailer
that referenced
this pull request
Jul 20, 2022
…(gassan) This PR was merged into the 6.2 branch. Discussion ---------- [Mailer] `max_per_second` option configurable via DSN | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | symfony/symfony-docs#16800 This option is available since 5.1, but it was impossible to configure it by dsn. Commits ------- a377f2e104 made max_per_second option configurable by dsn
javiereguiluz
added
Waiting feedback
and removed
Waiting Code Merge
OskarStark
approved these changes
Jul 29, 2022
javiereguiluz
force-pushed
the
max-per-second
branch
from
4c1e9aa to
7fddf4d
Compare
|
Gassan, thanks and congrats on your first Symfony Docs contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractTransport::setMaxPerSecond(float) was introduces in 5.1 but wan not configurable by dsn