Replace remaining annotations with attributes, remove remaining annotations configuration block #17223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Sep 2, 2022
xabbuh
reviewed
Sep 2, 2022
xabbuh
reviewed
Sep 2, 2022
| @@ -81,8 +81,8 @@ with the ``User`` class:: | |||
| } | |||
| } | |||
|
|
|||
| Beware that this feature is already provided by the `@ParamConverter`_ | |||
| annotation from the SensioFrameworkExtraBundle. If you have that bundle | |||
| Beware that this feature is already provided by the `#[ParamConverter]`_ | |||
There was a problem hiding this comment.
Should we refer to the MapEntity (see symfony/symfony#43854) here instead?
There was a problem hiding this comment.
Actually, I would be in favor of changing the whole Custom Value Resolver example because there is already a native UserValueResolver. But I don't know what could be used instead!
There was a problem hiding this comment.
Let's keep it as is then for now and rethink the whole example in a different PR.
xabbuh
previously approved these changes
Sep 9, 2022
xabbuh
approved these changes
Sep 9, 2022
OskarStark
approved these changes
Sep 10, 2022
…ations configuration block
javiereguiluz
force-pushed
the
feature/various-attributes
branch
from
1cacb5b to
6c15670
Compare
|
Thank you Romain. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the last remaining annotations in the documentation with the attributes.
I think this is the last PR to fix #16877, unless I missed some other annotations.