[HttpFoundation] replace $request->request by $request->getPayload()
#19225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm 👍 about this. Let's ask other people from Symfony Docs because this is an important change: @wouterj, @xabbuh, @OskarStark Thanks. |
javiereguiluz
added
the
Waiting team decision
|
I am fine with the change |
javiereguiluz
added
Status: Reviewed
and removed
Status: Needs Review
Waiting team decision
javiereguiluz
force-pushed
the
httpfoundation/use-getPayload-function
branch
from
e055185 to
00e9b45
Compare
|
Thanks Matthieu. |
javiereguiluz
added a commit
to symfony/demo
that referenced
this pull request
Feb 19, 2024
This PR was merged into the main branch. Discussion ---------- Update BlogController.php I replace `$request->request` by `$request->getPayload()` References: - https://symfony.com/blog/new-in-symfony-6-3-request-payload - symfony/symfony-docs#19225 Commits ------- 98e366f Update BlogController.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering new function getPayload added in code #49614, what do you think about replace
$request->requestby$request->getPayloadin documentation ?