Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webhook] show make:webhook #19810

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Conversation

jrushlow
Copy link
Contributor

@jrushlow jrushlow commented Apr 21, 2024

Since v1.58.0 (https://github.com/symfony/maker-bundle/releases/tag/v1.58.0) - MakerBundle has a make:webhook command (symfony/maker-bundle#1491) that generates a basic ConsumerInterface implementation.

  • Milestone 7.1 is incorrect

@carsonbot carsonbot added this to the 7.1 milestone Apr 21, 2024
@carsonbot carsonbot changed the title [webhook] show make:webhook [Webhook] show make:webhook Apr 21, 2024
@jrushlow jrushlow changed the base branch from 7.1 to 6.4 April 21, 2024 08:51
@javiereguiluz javiereguiluz modified the milestones: 7.1, 6.4 Apr 23, 2024
@javiereguiluz javiereguiluz merged commit 3027a9c into symfony:6.4 Apr 23, 2024
3 checks passed
@javiereguiluz
Copy link
Member

This is a nice new feature. Thanks for the contribution Jesse.

However, while merging I reworded this. See 86c9fe2. Changes:

  • Moved to a new section called Creating a Custom Webhook. We're still missing that section, but at least we can show this tip for readers.
  • I reworded this --> "to generate the files needed to use the Webhook component" because it looks like you need to generate some files to use Webhook, but you only need them if you are creating your own Webhook, not using the existing ones.

@jrushlow jrushlow deleted the feature/make-webhook branch April 23, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants