[Security] Tell about stateless CSRF protection #20964
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
csrf
branch
2 times, most recently
from
a9af992 to
3b50c2b
Compare
OskarStark
reviewed
May 15, 2025
OskarStark
reviewed
May 15, 2025
Kocal
reviewed
May 15, 2025
stof
reviewed
May 15, 2025
| @@ -1164,7 +1198,8 @@ settings is configured. | |||
|
|
|||
| For more details, see :doc:`/forms`. | |||
|
|
|||
| .. _reference-form-field-name: | |||
| csrf_protection | |||
| ''''''''''''''' | |||
There was a problem hiding this comment.
This header starting a section with no content looks wrong to me.
There was a problem hiding this comment.
it's currently missing, eg field_name is under csrf_protection
this declares one more nesting level
There was a problem hiding this comment.
I suggest keeping the markers consistent in the file then, by using . as the marker below ~ and another marker for the lower level (i.e. using . here and changing the marker of field_name and of your 2 new settings). It will reduce the risk of breaking the structure with future changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20306