Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Sphinx configuration instructions #3332

Closed
wants to merge 1 commit into from

Conversation

romaricdrigon
Copy link
Contributor

Hi,

While starting contributing, I ran into an error in Sphinx configuration.
The syntax of the configuration file should be slightly modified, here I propose to add a "tip", for users who may encounter the same issue.

Q A
Doc fix? yes
New docs? kinda: added a tip
Applies to N/A
Fixed tickets none

@wouterj
Copy link
Member

wouterj commented Dec 14, 2013

I think you did something wrong, in the end it should look like this: https://github.com/WouterJ/symfony-docs/blob/travis_integration/conf.py#L34

@xabbuh
Copy link
Member

xabbuh commented Dec 15, 2013

The problem might be that people are not familiar with our use of the ellipses. Thus, you might be tempted to append the whole extensions line to your config file which results in the error message @romaricdrigon pointed out. Because of this I am 👍 to add some kind of tip.

@wouterj
Copy link
Member

wouterj commented Dec 15, 2013

but this tip suggests that you should remove the other extensions.

@xabbuh
Copy link
Member

xabbuh commented Dec 15, 2013

Yeah, the tip is not clear enough. It should be rewritten in such that you have to add the Symfony docs related extensions to the list of already configured extensions if they exist.

@wouterj wouterj mentioned this pull request Dec 16, 2013
4 tasks
@romaricdrigon
Copy link
Contributor Author

On second thoughts yes the tip can be misleading; I'll think about another phraisng

@@ -211,6 +211,31 @@ Installing the Sphinx extensions
# set URL for API links
api_url = 'http://api.symfony.com/master/%s'

.. tip::

It seems that with newest Sphinx versions you may receive an error such
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems sounds too unreliable... what about With newest Sphinx versions you may sometimes receive [...]? That, if the errors happen only sometimes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't depend on the sphinx version. It depends on whether someone understands our ellipses usage or not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note comes from the possibility (based on what we saw at the hack day), that the newest version of Sphinx may have extensions = [] instead of extensions = ['lots of things'] (meaning it's blank in newer versions). That was part of the reason for the confusion.

weaverryan added a commit that referenced this pull request Mar 20, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

[WIP] Travis integration

| Q   | A
| --- | ---
| Doc fix? | no
| New docs? | no
| Applies to | all
| Fixed tickets | #2722, #3332

##### Todo

 - [x] Using sparse checkout
 - [x] Update contributing docs
 - [ ] Squashing commits
 - [ ] Activate Travis hook (@fabpot)

Commits
-------

37eb137 Update documentation
8dec729 sparse checkouts
b6f693e Added CMF
b1d9e62 Revert changes
6cad008 Updated travis config
c515613 Added .gitignore
85b1b02 Try to supress bundle doc warnings
f3cb8b1 Fixed submodules
71a2ff4 Added needed config files
d312683 Added sphinx files
@weaverryan
Copy link
Member

Closing this now that we've gone a step further and included the build details in the repository itself :).

Though, perhaps now we can take a look back at these instructions and update them to use the new build stuff - I don't think we've done that yet.

Cheers!

@weaverryan weaverryan closed this Apr 2, 2014
@xabbuh
Copy link
Member

xabbuh commented Apr 2, 2014

Well, there's not much left to do besides installing Sphinx and its extensions and running make html I guess. Which is afaics reflected in the docs, isn't it?

@weaverryan
Copy link
Member

@xabbuh - you're right, I don't know why I thought that needed more work. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants