doctrine file upload example uses dir -- caution added #3419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .. caution:: | ||
|
|
||
| Using lifecycle callbacks is a limited technique that has some drawbacks | ||
| but it is good enough to show the basic idea. If say you want to remove |
There was a problem hiding this comment.
How about remove but it is good enough to show the basic idea and just end the sentence after drawbacks.?
if you say -> if you want
|
Ping @cordoval! :) |
|
I will correct this now @weaverryan thanks, I will demo Gush usage in doing this 👶 |
~ gsh p:squash 3419 Luiss-MacBook-Pro-3 [21:16:36]
OUT > Fetching origin
ERR > From github.com:symfony/symfony-docs
42c80d1..67b7bbd 2.3 -> origin/2.3
ERR > bede4c3..5ba2227 2.4 -> origin/2.4
ERR > 6db5f23..c6ac96c master -> origin/master
ERR > * [new branch] remove-typo -> origin/remove-typo
OUT > Fetching cordoval
ERR > Already on '3363-doctrine-file-upload-example-uses-dir'
OUT > Your branch is up-to-date with 'cordoval/3363-doctrine-file-upload-example-uses-dir'.
OUT > [3363-doctrine-file-upload-example-uses-dir 1620ed8] 3363-doctrine-file-upload-example-uses-dir
1 file changed, 9 insertions(+)
ERR > To git@github.com:cordoval/symfony-docs.git
ERR > + b50519a...1620ed8 3363-doctrine-file-upload-example-uses-dir -> 3363-doctrine-file-upload-example-uses-dir (forced update)
OUT > Branch 3363-doctrine-file-upload-example-uses-dir set up to track remote branch 3363-doctrine-file-upload-example-uses-dir from cordoval.👶 |
|
right back at ya @weaverryan pong 👶 |
| Using lifecycle callbacks is a limited technique that has some drawbacks. | ||
| If you want to remove the hard coded ``__DIR__`` reference inside | ||
| the ``Document::getUploadRootDir()`` method, the best way is to start | ||
| using explicit :doc:`doctrine listeners </cookbook/doctrine/event_listeners_subscribers>` |
There was a problem hiding this comment.
I would terminate this sentence at the end of this line. Then you can continue on the following line with "There you will be able [...]"
weaverryan
added a commit
that referenced
this pull request
Jan 21, 2014
…ordoval) This PR was merged into the 2.3 branch. Discussion ---------- doctrine file upload example uses dir -- caution added | Q | A | | --- | --- | | Doc fix? | yes | | New docs? | no | | Applies to | 2.3+ | | Fixed tickets | #3363 | | License | CC-ASA 3.0 Unported | Sent using [Gush](https://github.com/cordoval/gush) Commits ------- 1620ed8 3363-doctrine-file-upload-example-uses-dir
weaverryan
added a commit
that referenced
this pull request
Jan 21, 2014
|
Thanks for the update @cordoval! Merged in :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sent using Gush