-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type fix in remove.rst #3493
Type fix in remove.rst #3493
Conversation
Ironically, your PR title also need a typo fox .. fix 😉 |
from the bundle. Searching for the bundle alias string may help you spot | ||
them (e.g. ``acme_demo`` for bundles depending on AcmeDemoBundle). | ||
If one bundle relies on another, in most cases it means that it uses some | ||
services from the bundle. Searching for a ``acme_demo`` string may help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not an acme_demo string
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw. do you think it's better to use acme_demo
here instead of the more generic tip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we changed it to the current way just a week ago, not sure if this was intended by @weaverryan
Ah, of course @xabbuh - I don't know how I did that :). Fixed back now, with just that little typo fix. Thanks! |
Great! :) |
Hi guys!
Very minor typo fix... leaving the PR format off.
Thanks!