Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type fix in remove.rst #3493

Merged
merged 1 commit into from
Feb 11, 2014
Merged

Type fix in remove.rst #3493

merged 1 commit into from
Feb 11, 2014

Conversation

weaverryan
Copy link
Member

Hi guys!

Very minor typo fix... leaving the PR format off.

Thanks!

@wouterj
Copy link
Member

wouterj commented Jan 20, 2014

Ironically, your PR title also need a typo fox .. fix 😉

from the bundle. Searching for the bundle alias string may help you spot
them (e.g. ``acme_demo`` for bundles depending on AcmeDemoBundle).
If one bundle relies on another, in most cases it means that it uses some
services from the bundle. Searching for a ``acme_demo`` string may help
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not an acme_demo string?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw. do you think it's better to use acme_demo here instead of the more generic tip?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we changed it to the current way just a week ago, not sure if this was intended by @weaverryan

@weaverryan
Copy link
Member Author

@xabbuh you're right with an acme_demo string - I've fixed that, thanks :). But I don't understand your other comment:

do you think it's better to use acme_demo here instead of the more generic tip?

The last change before this PR was sha: a4d804d

Thanks!

@xabbuh
Copy link
Member

xabbuh commented Feb 3, 2014

do you think it's better to use acme_demo here instead of the more generic tip?

The last change before this PR was sha: a4d804d

Yes, I see. But you revert @cordoval's change and I was wondering if that was intended.

weaverryan added a commit that referenced this pull request Feb 11, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Type fix in remove.rst

Hi guys!

Very minor typo fix... leaving the PR format off.

Thanks!

Commits
-------

efaad48 Fixing typo - thanks to @xabbuh
@weaverryan weaverryan merged commit efaad48 into 2.3 Feb 11, 2014
@weaverryan weaverryan deleted the remove-typo branch February 11, 2014 00:36
@weaverryan
Copy link
Member Author

Ah, of course @xabbuh - I don't know how I did that :). Fixed back now, with just that little typo fix.

Thanks!

@xabbuh
Copy link
Member

xabbuh commented Feb 11, 2014

Great! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants