Clarify service parameters usages #3528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Parameters do not need to be flat strings, they can also be arrays. For the XML | ||
| format, you need to use the ``type="collection"`` attribute for all parameters that are | ||
| arrays. | ||
| Parameters do not need to be flat strings, they can also contain array values. |
There was a problem hiding this comment.
changed this to array values, to make it explicitly clear that this isn't a way to inherit parameters.
|
👍 nice addition! |
| The used ``.`` notation is just a | ||
| :ref:`Symfony convention <service-naming-conventions>` to make parameters | ||
| easier to read. Parameters are just flat key-value elements, they can't be | ||
| inherited. |
There was a problem hiding this comment.
how about can't be organized into a nested array? What do you think - I wasn't totally clear on "inherited".
There was a problem hiding this comment.
can you make this change real quick? That'll let me merge without any mods :)
|
Awesome, thanks Wouter! |
weaverryan
added a commit
that referenced
this pull request
Feb 11, 2014
This PR was merged into the 2.3 branch. Discussion ---------- Clarify service parameters usages | Q | A | --- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | IRC On the IRC channel, there was some confusing about parameters. The dot notation looked like parameters are one big namespaced tree, with each group a different node. This PR adds a caution, so people really know it's just a convention and parameters are just key-value elements. Commits ------- aaddfcd Applied comment 05492b2 Clarify parameters conventions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the IRC channel, there was some confusing about parameters. The dot
notation looked like parameters are one big namespaced tree, with each
group a different node.
This PR adds a caution, so people really know it's just a convention and
parameters are just key-value elements.