Skip to content

Update testing.rst #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2014
Merged

Update testing.rst #3764

merged 3 commits into from
May 28, 2014

Conversation

nayzo
Copy link
Contributor

@nayzo nayzo commented Apr 4, 2014

No description provided.

xabbuh
xabbuh reviewed Apr 4, 2014
View reviewed changes
book/testing.rst
@@ -492,6 +492,11 @@ If you want the client to automatically follow all redirects, you can
force him with the ``followRedirects()`` method::

$client->followRedirects();

Also if you want to prevent the client from following any redirect, you can
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comma after Also

@wouterj
Copy link
Member

wouterj commented May 21, 2014

Hmm, it is disabled by default (when using the full-stack framework), so why would you want to disable it?

I think it's a pretty specific need, so maybe a little sentence "If you pass false, the redirects will no longer be followed." will do the trick better. What do you think?

@nayzo
Copy link
Contributor Author

nayzo commented May 21, 2014

it's a specific need but very useful, and must be clarified.
I already updated the commit

@weaverryan
Copy link
Member

Great suggestion on the wording Wouter and thanks @nayzo for adding this - I think it reads very well now. Cheers!

@weaverryan weaverryan merged commit 804b686 into symfony:2.3 May 28, 2014
weaverryan added a commit that referenced this pull request May 28, 2014
@weaverryan
minor #3764 Update testing.rst (NAYZO)
f617ff8 
This PR was merged into the 2.3 branch.

Discussion
----------

Update testing.rst

Commits
-------

804b686 Update testing.rst
9878be6 Update testing.rst
02974c2 Update testing.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nayzo @wouterj @weaverryan @xabbuh