Skip to content

[Cookbook][Configuration] tweaks for the web server configuration chapter #4142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2014

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Aug 17, 2014

Q A
Doc fix? no
New docs? yes
Applies to all
Fixed tickets

Tweaks to #3915 as suggested by @weaverryan.

files. Including images, stylesheets and JavaScript files. It is also where the
front controllers live. For more details, see the :ref:`the-web-directory`.
The preferred way to test your Symfony2 application is to use PHP's internal
web server. However, when using an older PHP versionor when running the application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo here, versionor instead of version or

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @Baptouuuu

The web directory is the home of all of your application's public and static
files. Including images, stylesheets and JavaScript files. It is also where the
front controllers live. For more details, see the :ref:`the-web-directory`.
The preferred way to test your Symfony2 application is to use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"test" makes me think of something like functional testing, not developing. How about:

The easiest way to develop your application is to use...

@xabbuh xabbuh force-pushed the issue-3915-tweaks branch from 24c18c7 to 93bbd14 Compare August 21, 2014 16:16
@xabbuh
Copy link
Member Author

xabbuh commented Aug 21, 2014

Thanks for your extensive feed back @weaverryan!

@weaverryan
Copy link
Member

Awesome job @xabbuh!

@weaverryan weaverryan merged commit 93bbd14 into symfony:2.3 Aug 22, 2014
weaverryan added a commit that referenced this pull request Aug 22, 2014
…figuration chapter (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Cookbook][Configuration] tweaks for the web server configuration chapter

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | all
| Fixed tickets |

Tweaks to #3915 as suggested by @weaverryan.

Commits
-------

93bbd14 tweaks for the web server configuration chapter
@xabbuh xabbuh deleted the issue-3915-tweaks branch August 22, 2014 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants