-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed version for composer install #4171
Conversation
👍 @zomberg thanks for fixing this issue. @wouterj @weaverryan this is a quick win that can be merged right away. |
@javiereguiluz Hmm. But why wouldn't we always recommend the latest version? Especially for the quick tour, I would want them seeing the latest and greatest. What do you think? |
@weaverryan But then there was no reason to maintain three versions of the quick tour. With the current situation, people may believe that they should choose the proper version of the quick tour from the version switcher. If they then got installation instructions for a different version, they would be confused, wouldn't they? |
My only concern is that they might be following the 2.3.x tutorial (for whatever reason they don't follow the latest tutorial) but they are using the 2.6.x version. The tutorial is so basic that there should not be BC problems, but who knows. |
I like @xabbuh's proposal. Why do we need different versions of the Quick Start tutorial? |
This fix wrong: ~2.3 or ~2.4 (or ~2.5) install latest 2.x.x version (currently it's 2.5.x). If you decide use different versions for different versions of Symfony version must be specified as:
|
I think this is not too important of an issue, because we'll be replacing the installer soon. And when we do, I think we will need to look through the docs and start removing installation instructions and pointing simply to symfony.com/download and making that the one path of installation. On that page (or the installer) it'll have details about downloading the latest version of the LTS. The quick tour is a spot for "showing a newcomer about Symfony". And so I think we should always recommend the latest version of Symfony. But again, this will all need to be changed soon anyways. So:
Thanks! |
This PR was merged into the 2.3 branch. Discussion ---------- Fixed version for composer install Commits ------- cecd6d7 Fixed version for composer install
No description provided.