provide node path on configuration #4249
Conversation
If you no provide node path in assetic configuration, UglifyCssFilter throw a `RuntimeException: Path to node executable could not be resolved.`
|
Actually, as long as the name of the binary is |
|
@xabbuh i was updated the PR as you indicate. In my ubuntu14.04 i was installed node via apt and binary name is nodejs |
| @@ -111,6 +111,34 @@ your JavaScripts: | |||
|
|
|||
| You now have access to the ``uglifyjs2`` filter in your application. | |||
|
|
|||
| Configure the ``node binary`` | |||
| ---------------------------------- | |||
There was a problem hiding this comment.
You should use the name number of - characters as there are characters in the headline.
There was a problem hiding this comment.
The format that we use for the documentation is very strict for things like the length of the headings underlining. So please, reduce the underneath line length to match the length of the title. Thanks.
There was a problem hiding this comment.
The funny thing is that reST only complain about underlines that are too short.
There was a problem hiding this comment.
@xabbuh reST allows longer underlines. Matching the length exactly is a matter of coding standards
|
I think that i solved your comments |
|
@desarrolla2 thanks for your quick response to the comments and for having created this documentation. I know that you've been a Symfony developer for a long time, but if I'm right, this is your first documentation contribution. If this is true, congratulations! By the way, you mentioned the How to Contribute to Symfony Documentation guide that we recently updated. If you found something hard to understand or some missing explanation, please feel free to open an issue in this repository. Thanks. |
| ----------------------------- | ||
|
|
||
| Assetic tries to find the node binary automatically. If it cannot be found, you'll | ||
| be able to configure its location using the ``node`` key: |
There was a problem hiding this comment.
How about:
If it cannot be found, you can configure its location...
|
I just left a comment, but actually, this looks great to me. So I'm going to merge and change the language myself in that tiny spot. Thanks so much for this! |
This PR was merged into the 2.3 branch. Discussion ---------- provide node path on configuration | Q | A | ------------- | --- | Doc fix? | yes | New docs? | No | Applies to | all | Fixed tickets | If you no provide node path in assetic configuration, UglifyCssFilter throw a `RuntimeException: Path to node executable could not be resolved.` Commits ------- ab3dbef update uglifyjs.rst 1a5c0a6 Update uglifyjs.rst 1621071 Update uglifyjs.rst 2258ac9 provide node path on configuration
* 2.3: [#4249] Tiny tweak to language update uglifyjs.rst Update uglifyjs.rst Update uglifyjs.rst provide node path on configuration
* 2.4: [#4249] Tiny tweak to language update uglifyjs.rst Update uglifyjs.rst Update uglifyjs.rst provide node path on configuration
* 2.5: [#4249] Tiny tweak to language update uglifyjs.rst Update uglifyjs.rst Update uglifyjs.rst provide node path on configuration
If you no provide node path in assetic configuration, UglifyCssFilter throw a
RuntimeException: Path to node executable could not be resolved.