[Components][HttpFoundation] Make a small grammatical adjustment #4276
Conversation
The original form of the phrase - «The other option is to specifically checking if a session has expired after the session is started.» - is not entirely grammatically correct, as the infinitive form of «to check» shall normally be used, or the gerund form, which is the form used in this commit.
| @@ -181,7 +181,7 @@ which runs reasonably frequently. The ``cookie_lifetime`` would be set to a | |||
| relatively high value, and the garbage collection ``gc_maxlifetime`` would be set | |||
| to destroy sessions at whatever the desired idle period is. | |||
|
|
|||
| The other option is to specifically checking if a session has expired after the | |||
| The other option is specifically checking if a session has expired after the | |||
There was a problem hiding this comment.
I'm far from native, so I can be completely wrong, but isn't "The other option is to specifically check if a session has expired after the session is started." better?
There was a problem hiding this comment.
FTR, English is not my native language either.
Actually, yes, as I wrote it in the commit message and PR description, I think both the infinitive form and the gerund form are grammatically correct, and, in this context, either may be used as subject complement (but I might also be wrong).
I guess the infinitive form is a bit more literary (although this is very subjective), which is less suitable in a context of technical documentation, and that's why I chose the gerund form in my commit.
Obviously, I'd be willing to commit again with the infinitive form if it's considered a better fit.
There was a problem hiding this comment.
I tend to agree with @wouterj here. But I'm also no native speaker. So, let's wait for @weaverryan for the final decision.
There was a problem hiding this comment.
Yep, @wouterj is right. To be clear, the language is wrong as it currently is. The best is:
The other option is to specifically check if a session has expired after the session is started.
fabschurt
changed the title
fabschurt
changed the title
…ustment (fabschurt) This PR was merged into the 2.3 branch. Discussion ---------- [Components][HttpFoundation] Make a small grammatical adjustment | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | n/a The original form of the phrase - «The other option is to specifically checking if a session has expired after the session is started.» - is not entirely grammatically correct, as the infinitive form of «to check» shall normally be used, or the gerund form, which is the form used in this commit. Commits ------- 3ad13a1 Make a small grammatical adjustment
|
Thanks Fabien for the report of the bad language! I've merged this in and changed the other word so that things are perfect - see sha: 4bada7c Cheers! |
* 2.3: [#4276] Making language correction we agreed on [Cookbook][External Parameters] Enhance description of environment variables Make a small grammatical adjustment
* 2.5: [#4276] Making language correction we agreed on Correct a typo: replace "then" by "the". Correct a typo: remove unnecessary "the" word. Remove horizontal scrollbar and change event name to follow conventions Remove horizontal scrollbar Update choice.rst Improve readability support Varnish in configuration blocks minor #4285 Update security.rst (placid2000) Update security.rst [Cookbook][External Parameters] Enhance description of environment variables Make a small grammatical adjustment
The original form of the phrase - «The other option is to specifically
checking if a session has expired after the session is started.» - is
not entirely grammatically correct, as the infinitive form of «to check»
shall normally be used, or the gerund form, which is the form used in
this commit.