-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
consistent table headlines #4435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xabbuh
commented
Nov 7, 2014
Q | A |
---|---|
Doc fix? | yes |
New docs? | no |
Applies to | all |
Fixed tickets |
👍 Cool. you're always blazing fast on these things! |
Otherwise I would forget them. ;) |
@xabbuh thanks for working on this! I have a comment about the new table syntax. In this table, columns are separated with two white spaces, while in the rest of the tables you use one white space. Instead of suggesting you to use also one white space on the first table, I'd like to ask you reconsider using always two white spaces. That's what I've been using and I think that it improves readability. |
@javiereguiluz There was no specific reason. Honestly, I simply didn't realise that there already were two spaces. Personally, I don't really care if we use one space or two spaces. @wouterj @weaverryan What are your thoughts on this? |
+1 for 2 spaces Op di 11 nov. 2014 18:33 schreef Christian Flothmann <
|
If both render ok, I'm also cool with 2 spaces - I guess the extra separation makes it a bit more readable in the source. |
Alright, do we wanna do that in this pull request or do you prefer a different one? |
@xabbuh This one if it's ok - it'll save me from merging up twice, which may involve a few conflicts :). |
b55dfa6
to
10b607b
Compare
Of course, no problem. Here we go. |
@xabbuh, beautiful - merged in and merged up to master! |