Modifying the best practice to use form_start() instead of <form #4465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -157,29 +157,15 @@ There are a lot of ways to render your form, ranging from rendering the entire | |||
| thing in one line to rendering each part of each field independently. The | |||
| best way depends on how much customization you need. | |||
|
|
|||
| The simplest way - which is especially useful during development - is to render | |||
| the form tags manually and then use ``form_widget()`` to render all of the fields: | |||
| One of thhe simplest ways - which is especially useful during development - | |||
|
Just pushed a typo fix for the typo discovered by @yguedidi. Ready to be merged now 👍 |
wouterj
added
Status: Reviewed
HttpFoundation
and removed
HttpFoundation
Status: Needs Work
labels
|
Thanks Wouter and @yguedidi! |
weaverryan
added a commit
that referenced
this pull request
Nov 20, 2014
… of <form (weaverryan, WouterJ) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4465). Discussion ---------- Modifying the best practice to use form_start() instead of <form | Q | A | --- | --- | Doc fix? | no | New docs? | no | Applies to | 2.3+ | Fixed tickets | #4402 Hi guys! See #4402. This proposes recommending to use `form_start` for the reasons there. There are pros and cons, but after nice chat, I think the pros outweigh the cons. /cc @webmozart Thanks! Commits ------- ae3b3cd Fixed typo f1708f5 Modifying the best practice to use form_start() instead of <form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
See #4402. This proposes recommending to use
form_startfor the reasons there. There are pros and cons, but after nice chat, I think the pros outweigh the cons./cc @webmozart
Thanks!