Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update standard link to remove absolute URL #4535

Closed
wants to merge 2 commits into from
Closed

Conversation

jms85
Copy link
Contributor

@jms85 jms85 commented Nov 29, 2014

No description provided.

@@ -337,6 +337,5 @@ in a matter of seconds.
.. _`Doctrine project`: http://www.doctrine-project.org/
.. _`fixture class`: http://symfony.com/doc/master/bundles/DoctrineFixturesBundle/index.html#writing-simple-fixtures
.. _`PSR-1`: http://www.php-fig.org/psr/psr-1/
.. _`PSR-2`: http://www.php-fig.org/psr/psr-2/
.. _`the Symfony Code Standards`: http://symfony.com/doc/current/contributing/code/standards.html
.. _`PSR-2`: http://www.php-fig.org/psr/psr-2//contributing/code/standards.htm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something did go wrong here. This URL should not be changed if I'm correct

@jms85
Copy link
Contributor Author

jms85 commented Nov 29, 2014

@wouterj
Ups, it should be ok now

@xabbuh
Copy link
Member

xabbuh commented Jan 2, 2015

@jms85 Happy new year! :) Thanks you for improving the Symfony docs with your contribution. I found some more internal links that didn't use the doc role. So, I cherry picked your commit and added some changes on top of it. That's why I'm going to close here. Thanks again!

@xabbuh xabbuh closed this Jan 2, 2015
wouterj added a commit that referenced this pull request Jan 2, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

use the doc role for internal links

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4535

Commits
-------

a654c9c use the doc role for internal links
7ffd5b9 Update standard link to remove absolute URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants