Update data_collector.rst #4633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple change...would have saved me several hours of guessing.
|
good one, 👍 |
| @@ -151,7 +151,7 @@ All blocks have access to the ``collector`` object. | |||
| echo base64_encode(file_get_contents($_SERVER['argv'][1])); | |||
|
|
|||
| To enable the template, add a ``template`` attribute to the ``data_collector`` | |||
| tag in your configuration. For example, assuming your template is in some | |||
| tag in your configuration. Make sure the ``id`` attribute is the same string you used for the getName() method. For example, assuming your template is in some | |||
There was a problem hiding this comment.
getName() should also be enclosed by literals (double backticks). And can you please wrap lines after the first word that crosses the 72nd character? Thanks. :)
|
Thank you @seangallavan. Looks good beside my minor comment. |
Changes made. Thanks.
| @@ -151,7 +151,8 @@ All blocks have access to the ``collector`` object. | |||
| echo base64_encode(file_get_contents($_SERVER['argv'][1])); | |||
|
|
|||
| To enable the template, add a ``template`` attribute to the ``data_collector`` | |||
| tag in your configuration. For example, assuming your template is in some | |||
| tag in your configuration. Make sure the ``id`` attribute is the same string you used | |||
| for the ``getName()`` method. For example, assuming your template is in some | |||
There was a problem hiding this comment.
could you please remove one of the two spaces before "For example"?
Updated. Thanks for your patience.
|
Thanks for the update @seangallavan. Unfortunately, we are not notified when new commits are pushed to a pull request. Will you be able to rebase your changes so that they can be applied cleanly? |
|
I've done the rebase in #5280. Thanks for starting this @seangallavan ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple change...would have saved me several hours of guessing.