Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update controller.rst #4747

Closed
wants to merge 2 commits into from
Closed

Update controller.rst #4747

wants to merge 2 commits into from

Conversation

ifdattic
Copy link
Contributor

@ifdattic ifdattic commented Jan 3, 2015

Q A
Doc fix? yes
New docs? no
Applies to 2.3
Fixed tickets

wouterj
wouterj reviewed Jan 3, 2015
View reviewed changes
book/controller.rst
@@ -5,7 +5,7 @@ Controller
==========

A controller is a PHP function you create that takes information from the
HTTP request and constructs and returns an HTTP response (as a Symfony
HTTP request to construct and return an HTTP response (as a Symfony
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure about this change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about "to create and return"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it's more about grammar than word usage. I think A controller is still the one doing stuff:

A controller:

  • takes information from the HTTP request
  • constructs an HTTP response
  • returns the HTTP response

So imo, it's still "takes information from the HTTP request and creates and returns an HTTP response".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, sounds better this way.

@xabbuh
Copy link
Member

xabbuh commented Mar 8, 2015

ping @ifdattic :)

@ifdattic
Copy link
Contributor Author

ifdattic commented Mar 8, 2015

@xabbuh should I revert line 8?

@xabbuh
Copy link
Member

xabbuh commented Mar 8, 2015

@ifdattic I think you can replace it with @wouterj's suggestion: "takes information from the HTTP request and creates and returns an HTTP response" (this replaces "constructs" with "creates").

@wouterj wouterj mentioned this pull request Apr 3, 2015
Merged
@wouterj
Copy link
Member

wouterj commented Apr 3, 2015

rebased this PR in #5143 Thanks!

@wouterj wouterj closed this Apr 3, 2015
@ifdattic ifdattic deleted the patch-6 branch April 5, 2015 05:00
wouterj added a commit that referenced this pull request Apr 7, 2015
@wouterj
minor #5143 Rebased #4747 (ifdattic)
0dc6204 
This PR was merged into the 2.3 branch.

Discussion
----------

Rebased #4747

This is just a rebase #4747

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets |

Commits
-------

3b12cff Update controller.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ifdattic @xabbuh @wouterj