Update validation.rst #4789
Update validation.rst #4789
Conversation
| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | Some fixes can be a bit "controversial". Due to PR https://github.com/symfony/symfony-docs/pull/4779/files not all changes were made. Something to keep in mind is what due to https://github.com/symfony/symfony-docs/pull/4779/files using `Assert\...` if arguments are kept on the same line the possibility of horizontal scrollbar (especially on the smaller screens) is quite high. Also for most use cases I think adding PHP constraints is better if arguments are on different lines ("easier to read" and easier to spot errors
|
I would like to split line 344 to remove horizontal scrollbar, but wasn't sure of the best way to do it |
| @@ -35,7 +35,7 @@ application. The goal of validation is to tell you if the data | |||
| of an object is valid. For this to work, you'll configure a list of rules | |||
| (called :ref:`constraints <validation-constraints>`) that the object must | |||
| follow in order to be valid. These rules can be specified via a number of | |||
| different formats (YAML, XML, annotations, or PHP). | |||
| different formats (annotations, YAML, XML, or PHP). | |||
There was a problem hiding this comment.
While it's not your fault, you should remove the serial comma before "or"
There was a problem hiding this comment.
Yea, I thought it wasn't needed but just left it as is, will fix on the next commit.
|
|
Yes, thank you, completely slipped my mind that is how you do in YAML |
| @@ -476,7 +486,7 @@ If you're ever unsure of how to specify an option, either check the API document | |||
| for the constraint or play it safe by always passing in an array of options | |||
| (the first method shown above). | |||
|
|
|||
| Translation Constraint Messages | |||
| Translating Constraint Messages | |||
There was a problem hiding this comment.
You need to add the former label to be BC:
.. _translation-constraint-messages:
Translating Constraint Messages
-------------------------------There was a problem hiding this comment.
Thanks, will change it now
|
What do we do here? |
|
Closing as none of the code blocks are violating the 85 character limit we've decided on after this PR was opened (only the schema definitions do, but we don't care about them). The only other change in here is implementing UserInterface, which is already done. |
Some fixes can be a bit "controversial".
Due to PR https://github.com/symfony/symfony-docs/pull/4779/files not all changes were made.
Something to keep in mind is what due to https://github.com/symfony/symfony-docs/pull/4779/files using
Assert\...if arguments are kept on the same line the possibility of horizontal scrollbar (especially on the smaller screens) is quite high.Also for most use cases I think adding PHP constraints is better if arguments are on different lines ("easier to read" and easier to spot errors