- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 5.3k
 
Add custom link labels where Cookbook articles titles looked wrong #4857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            weaverryan
  merged 1 commit into
  symfony:2.3
from
javiereguiluz:improve_best_practices_crossrefs
  
      
      
   
  Jan 16, 2015 
      
    
                
     Merged
            
            Add custom link labels where Cookbook articles titles looked wrong #4857
                    weaverryan
  merged 1 commit into
  symfony:2.3
from
javiereguiluz:improve_best_practices_crossrefs
  
      
      
   
  Jan 16, 2015 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
      
  
  Member
      
  
  
      
          
      
      
            javiereguiluz
  
      
      
      commented
        Jan 16, 2015 
      
    
  
| Q | A | 
|---|---|
| Doc fix? | yes | 
| New docs? | no | 
| Applies to | all | 
| Fixed tickets | #4822 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the [...]?
| 
           Thanks Javier! @xabbuh - I'll take care of your line note right now - I agree about the missing word  | 
    
    
  weaverryan 
      added a commit
      that referenced
      this pull request
    
      Jan 16, 2015 
    
    
      
  
    
      
    
  
…ked wrong (javiereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Add custom link labels where Cookbook articles titles looked wrong | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #4822 Commits ------- 1b31ad1 Add custom link labels where Cookbook articles titles looked wrong
    
  weaverryan 
      added a commit
      that referenced
      this pull request
    
      Jan 16, 2015 
    
    
  
    
  weaverryan 
      added a commit
      that referenced
      this pull request
    
      Jan 16, 2015 
    
    
      
  
    
      
    
  
* 2.3: [#4857] Adding missing word thanks to xabbuh Fixing bad english thanks to xabbuh Adding missing words thanks to javiereguiluz [#4643] Minor english changes to make things even smoother (though they were correct before) replace API link for SwiftmailerBundle Update security.rst Update routing.rst don't output message from AuthenticationException Add custom link labels where Cookbook articles titles looked wrong Removed a leftover comma in security config sample [#4141] Tweaks to the new form csrf caching entry How to override vendor directory location - fix How to override vendor directory location - fix How to override vendor directory location
    
  weaverryan 
      added a commit
      that referenced
      this pull request
    
      Jan 16, 2015 
    
    
      
  
    
      
    
  
* 2.5: [#4857] Adding missing word thanks to xabbuh Fixing bad english thanks to xabbuh Adding missing words thanks to javiereguiluz [#4643] Minor english changes to make things even smoother (though they were correct before) replace API link for SwiftmailerBundle Update security.rst Update routing.rst don't output message from AuthenticationException Add custom link labels where Cookbook articles titles looked wrong Fix code example Removed a leftover comma in security config sample [#4141] Tweaks to the new form csrf caching entry How to override vendor directory location - fix How to override vendor directory location - fix How to override vendor directory location
    
  weaverryan 
      added a commit
      that referenced
      this pull request
    
      Jan 18, 2015 
    
    
      
  
    
      
    
  
* 2.6: (30 commits) fix merge after removing @Security in 2.3 Reverting a commit on 2.5 branch, as it was only meant to be on 2.3 (so reverting after the merge) [#4735] Reverting what was left on the 2.5 branch after the merge conflict had already put back some of it Typo Fix: "allows to" should be "allows you to" Adding a link to log things in the prod environment [#4857] Adding missing word thanks to xabbuh move cautions to make them visible Fixing bad english thanks to xabbuh Adding missing words thanks to javiereguiluz language tweak thanks to xabbuh! Adding an example image of the debug_formatter [#4643] Minor english changes to make things even smoother (though they were correct before) replace API link for SwiftmailerBundle Update security.rst Update routing.rst don't output message from AuthenticationException Add custom link labels where Cookbook articles titles looked wrong Fix typo: BLOG => BLOB Fix code example Removed a leftover comma in security config sample ... Conflicts: reference/configuration/security.rst
    
  weaverryan 
      added a commit
      that referenced
      this pull request
    
      Jan 18, 2015 
    
    
      
  
    
      
    
  
* 2.7: (31 commits) fix merge after removing @Security in 2.3 Reverting a commit on 2.5 branch, as it was only meant to be on 2.3 (so reverting after the merge) [#4735] Reverting what was left on the 2.5 branch after the merge conflict had already put back some of it Typo Fix: "allows to" should be "allows you to" Adding a link to log things in the prod environment [#4857] Adding missing word thanks to xabbuh move cautions to make them visible Fixing bad english thanks to xabbuh Adding missing words thanks to javiereguiluz language tweak thanks to xabbuh! Adding an example image of the debug_formatter [#4643] Minor english changes to make things even smoother (though they were correct before) replace API link for SwiftmailerBundle Update security.rst Update routing.rst don't output message from AuthenticationException Add custom link labels where Cookbook articles titles looked wrong Fix typo: BLOG => BLOB Fix code example Removed a leftover comma in security config sample ...
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.