Skip to content

[Best Pracitices] restore example in the "Service: No Class Parameter" section #4886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2015
Merged

[Best Pracitices] restore example in the "Service: No Class Parameter" section #4886

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73ff5ea
restore the how to NOT do it example in the "Service: No Class Parame…
uvoelkel Jan 20, 2015
0a678d2
fixed indentation
uvoelkel Jan 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion best_practices/business-logic.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,12 @@ the class namespace as a parameter:
# app/config/services.yml

# service definition with class namespace as parameter
parameters:
slugger.class: AppBundle\Utils\Slugger

services:
app.slugger:
class: AppBundle\Utils\Slugger
class: "%slugger.class%"

This practice is cumbersome and completely unnecessary for your own services:

Expand Down