Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish #4586: Update routing.rst #5030

Merged
merged 1 commit into from
Mar 14, 2015
Merged

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Feb 20, 2015

Finished #4586

Original PR description:

add route name "blog_show" in first example

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets -

add route name "blog_show" in first example
@@ -45,7 +45,7 @@ The route is simple:
class BlogController extends Controller
{
/**
* @Route("/blog/{slug}")
* @Route("/blog/{slug}", name="blog_show")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single_blog sounds better?

@weaverryan
Copy link
Member

Thanks for finishing this! And thanks @guangle for starting it :)

@weaverryan weaverryan merged commit c75455f into symfony:2.3 Mar 14, 2015
weaverryan added a commit that referenced this pull request Mar 14, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Finish #4586: Update routing.rst

Finished #4586

Original PR description:

 > add route name "blog_show" in first example

| Q | A
| --- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | all
| Fixed tickets | -

Commits
-------

c75455f Update routing.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants