[Cookbook] Custom compile steps on Heroku #5088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bicpi
commented
Mar 17, 2015
bicpi
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | no |
| Applies to | all |
| Fixed tickets | #4217 (partially, list item 3) |
| Heroku's `custom compile steps`_. Let's say for example you want to remove the ``dev`` | ||
| front controller from your production environment on Heroku in order to avoid a | ||
| potential vulnerability. Adding a command to remove ``web/app_dev.php`` to Composer's | ||
| `post-install-cmds`_ would work, but it also removes the controller in your local |
There was a problem hiding this comment.
Just had a quick look: The reference for post-install-cmds is not defined making the build fail.
|
Anything's still missing in this PR? |
|
@bicpi apart from a rebase, no |
|
@wouterj Done, thanks for pointing out! |
|
Thanks! This is now labelled as finished |
|
WOW, this is very detailed - it's exactly the kind of stuff I was hoping for! Thanks Philipp! |
weaverryan
added a commit
that referenced
this pull request
May 3, 2015
This PR was merged into the 2.3 branch. Discussion ---------- [Cookbook] Custom compile steps on Heroku | Q | A | ------------- | --- | Doc fix? | no | New docs? | no | Applies to | all | Fixed tickets | #4217 (partially, list item 3) Commits ------- cb71ad0 [Cookbook] Custom compile steps on Heroku
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.