Reviewed Configuration cookbook articles #5098

javiereguiluz · 2015-03-19T15:33:14Z

Q	A
Doc fix?	yes
New docs?	no
Applies to	all
Fixed tickets	-

xabbuh · 2015-03-19T21:34:28Z

cookbook/configuration/apache_router.rst

-One of these ways is by letting Apache handle routes directly, rather than using Symfony for this task.
+Symfony, while fast out of the box, also provides various ways to increase that
+speed with a little bit of tweaking. One of these ways is by letting Apache
+handle routes directly, rather than using Symfony for this task.


The ApacheUrlMatcher as well as the ApacheMatcherDumper are deprecated. Should we add warning about this?

Yea, I think we should - I think this whole "article" is deprecated

I've added a note about not using Apache Router in aedaccd. Please tell me if it's OK. Thanks.

wouterj · 2015-03-20T00:18:34Z

cookbook/configuration/override_dir_structure.rst

@@ -80,6 +80,8 @@ method::

 Here you have changed the location of the directory to ``app/{environment}/logs``.

+.. _override-web-directory:


why adding this?

ah, see now. For consistency, I would prefer override-web-dir

Good point! I've updated the reference name. Thanks.

weaverryan · 2015-04-15T18:02:10Z

cookbook/configuration/apache_router.rst

@@ -93,7 +103,7 @@ Which should roughly output the following:

    # hello
    RewriteCond %{REQUEST_URI} ^/hello/([^/]+?)$
-    RewriteRule .* app.php [QSA,L,E=_ROUTING__route:hello,E=_ROUTING_name:%1,E=_ROUTING__controller:AppBundle\:Demo\:hello]
+    RewriteRule .* app.php [QSA,L,E=_ROUTING__route:hello,E=_ROUTING_name:%1,E=_ROUTING__controller:AppBundle\:Default\:hello]


This should be Greet, correct? To match the _controller above?

Fixed at sha: 808383b

This PR was merged into the 2.3 branch. Discussion ---------- Reviewed Configuration cookbook articles | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Commits ------- aedaccd Added a note against using the Apache Router 2feb801 Implemented all the changes suggested by reviewers 9f49497 Reviewed Configuration cookbook articles

…route information above

weaverryan · 2015-04-15T18:08:18Z

Thanks for all the re-reads Javier - I think it's very helpful!

* 2.3: [#5098] Minor fix so controller in dumped apache matches _controller route information above fix code block order Update process.rst [Cookbook] Add warning about Composer dev deps on Heroku Added a note against using the Apache Router Implemented all the changes suggested by reviewers Minor rewording Reviewed Configuration cookbook articles Reviewed Cache cookbook articles

* 2.6: [#5098] Minor fix so controller in dumped apache matches _controller route information above fix code block order Update process.rst [Cookbook] Add warning about Composer dev deps on Heroku Added a note against using the Apache Router Implemented all the changes suggested by reviewers Minor rewording Reviewed Configuration cookbook articles Reviewed Cache cookbook articles

* 2.8: [#5098] Minor fix so controller in dumped apache matches _controller route information above fix code block order Update process.rst [Cookbook] Add warning about Composer dev deps on Heroku Added a note against using the Apache Router Implemented all the changes suggested by reviewers Minor rewording Reviewed Configuration cookbook articles Reviewed Cache cookbook articles

…roller route information above

Reviewed Configuration cookbook articles

9f49497

xabbuh reviewed Mar 19, 2015
View reviewed changes

xabbuh added the Status: Needs Work label Mar 19, 2015

wouterj reviewed Mar 20, 2015
View reviewed changes

javiereguiluz added 2 commits March 25, 2015 08:42

Implemented all the changes suggested by reviewers

2feb801

Added a note against using the Apache Router

aedaccd

wouterj added Status: Reviewed and removed Status: Needs Work labels Mar 25, 2015

weaverryan reviewed Apr 15, 2015
View reviewed changes

weaverryan merged commit aedaccd into symfony:2.3 Apr 15, 2015

weaverryan added a commit that referenced this pull request Apr 15, 2015

[#5098] Minor fix so controller in dumped apache matches _controller …

808383b

…route information above

javiereguiluz pushed a commit to javiereguiluz/symfony-docs that referenced this pull request Sep 2, 2015

[symfony#5098] Minor fix so controller in dumped apache matches _cont…

e60e778

…roller route information above

javiereguiluz deleted the update_configuration_cookbook branch January 3, 2018 16:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reviewed Configuration cookbook articles #5098

Reviewed Configuration cookbook articles #5098

javiereguiluz commented Mar 19, 2015

xabbuh Mar 19, 2015

weaverryan Mar 23, 2015

javiereguiluz Mar 25, 2015

wouterj Mar 20, 2015

wouterj Mar 20, 2015

javiereguiluz Mar 25, 2015

weaverryan Apr 15, 2015

weaverryan Apr 15, 2015

weaverryan commented Apr 15, 2015

		@@ -80,6 +80,8 @@ method::

		Here you have changed the location of the directory to ``app/{environment}/logs``.

		.. _override-web-directory:

Reviewed Configuration cookbook articles #5098

Reviewed Configuration cookbook articles #5098

Conversation

javiereguiluz commented Mar 19, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

weaverryan commented Apr 15, 2015