Improve Choice Validation Constraint Example #5233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example came off sounding transphobic. Added "other" option.
| @@ -329,7 +329,7 @@ Some constraints, like :doc:`NotBlank </reference/constraints/NotBlank>`, | |||
| are simple whereas others, like the :doc:`Choice </reference/constraints/Choice>` | |||
| constraint, have several configuration options available. Suppose that the | |||
| ``Author`` class has another property called ``gender`` that can be set to either | |||
| "male" or "female": | |||
| "male", "female", or "other": | |||
There was a problem hiding this comment.
Can you please remove the comma in front of "or"? We don't use serial commas in the documentation.
|
This is a funny one :-) |
|
👍 |
|
Haha, indeed! With an error message of "Choose a valid gender." - that was certainly not the intention :). Thanks Ben! |
weaverryan
added a commit
that referenced
this pull request
May 23, 2015
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #5233). Discussion ---------- Improve Choice Validation Constraint Example Example came off sounding transphobic. Added "other" option. Commits ------- 3597020 Remove Serial Comma 4643ce1 Update validation.rst 8295129 Improve Choice Validation Constraint Example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example came off sounding transphobic. Added "other" option.