Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Components][Form] apply some fixes to the Form events chapter #5241

Merged
merged 1 commit into from
May 23, 2015

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 7, 2015

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets
  • remove serial commas
  • replace wrong event constant
  • replace reference to form events overview that did not provide any
    context with a more meaningful seealso section

@@ -69,6 +67,11 @@ Normalized data ``null``
View data ``null``
=============== ========

.. seealso::

See all form at a glance in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean with "all form"? Did you mean "all form events"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, yes, added the missing "events"

* remove serial commas
* replace wrong event constant
* replace reference to form events overview that did not provide any
  context with a more meaningful `seealso` section
@weaverryan
Copy link
Member

👍

@weaverryan weaverryan merged commit d9f7e4e into symfony:2.3 May 23, 2015
weaverryan added a commit that referenced this pull request May 23, 2015
…apter (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Components][Form] apply some fixes to the Form events chapter

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

* remove serial commas
* replace wrong event constant
* replace reference to form events overview that did not provide any
  context with a more meaningful `seealso` section

Commits
-------

d9f7e4e apply some fixes to the Form events chapter
@xabbuh xabbuh deleted the form-events-improvements branch May 23, 2015 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants