Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Translation] Add note about how to override translation in chi… #5293

Merged
merged 4 commits into from
Jun 27, 2015

Conversation

zebba
Copy link
Contributor

@zebba zebba commented May 23, 2015

Q A
Doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets #5193

Translation files are not aware of the inheritance tree and therefore
unaware of their parent. If you want to override translations from the
parent bundle be sure the loading order in ``AppKernel`` is parent > child.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the trailing whitespaces

@xabbuh
Copy link
Member

xabbuh commented May 23, 2015

Thank you for starting this @zebba. I just left you a few small comments.

zebba added 3 commits May 23, 2015 16:03
Minor editing.
Minor change.
Tackling the new line...
@zebba zebba changed the title [WIP] [Translation] Add note about how to override translation in chi… [Translation] Add note about how to override translation in chi… Jun 19, 2015
@zebba
Copy link
Contributor Author

zebba commented Jun 19, 2015

Ping @xabbuh

@xabbuh
Copy link
Member

xabbuh commented Jun 23, 2015

👍

@weaverryan weaverryan merged commit 32d8203 into symfony:2.3 Jun 27, 2015
weaverryan added a commit that referenced this pull request Jun 27, 2015
…in chi… (zebba)

This PR was merged into the 2.3 branch.

Discussion
----------

[Translation] Add note about how to override translation in chi…

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | #5193

Commits
-------

32d8203 Update override.rst
f91e424 Update override.rst
13e3351 Update override.rst
b80f46b [WIP] [Translation] Add note about how to override translation in child Bundle
@weaverryan
Copy link
Member

Thanks Sebastian! Easy merge :). Small tweak at sha: 5467a56 to link people to the cookbook on parent bundles, in case they don't know what we're talking about.

Cheers!

weaverryan added a commit that referenced this pull request Jun 28, 2015
* 2.8: (122 commits)
  moving options below basic usage
  changing a few orders of sections - mostly to move overridden after the main options
  Rewrite note a bit
  fix capitalization
  tweak headline to be consistent with 2.6
  [Contributing] [Standards] Added entry for identical comparison
  Wrap the table creation inside the class extending Command, so users know where the  comes. They can use it as standalone when needed
  [Serializer] Array Denormalization
  [Cookbook][Assetic] complete a sentence
  Fixing "Undefined method" error on Symfony 2.7
  [#5293] Tweak to link to the article about parent bundles
  Minor tweak to remove FOSUserBundle example and replace with a link to the doc about this
  overriding 3rd party bundles
  Adjust line wrapping
  Add formatting for file and method names
  Update load_balancer_reverse_proxy.rst
  removing upgrading.rst - this has already been moved into several documents in its own section
  [#5166] Minor tweaks
  Revert "Changed dump() to var_dump()"
  Changed dump() to var_dump()
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants