Kernel Events Proofreading after #4901 #5297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Literlas in the titles do work, but you can't reference them using |
Member
Author
|
Thanks @wouterj - I re-added the literals. Look good otherwise? |
reference/events.rst
Outdated
Member
There was a problem hiding this comment.
should be /components/http_kernel/introduction afaik
Member
|
apart from the typo (causing the build failure), perfect! |
Member
|
👍 |
weaverryan
added a commit
that referenced
this pull request
May 23, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Kernel Events Proofreading after #4901 | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | n/a Hi guys! This is a proofread of #4901. I removed the ticks in the titles - iirc, the ticks don't work in titles. I also fixed a few minor bugs I believe. Thanks! Commits ------- c7326da another fix! 106bda9 re-adding literals cd820d7 Proofreading after #4901
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
This is a proofread of #4901. I removed the ticks in the titles - iirc, the ticks don't work in titles. I also fixed a few minor bugs I believe.
Thanks!