Skip to content

Conversation

snoek09
Copy link

@snoek09 snoek09 commented May 30, 2015

Q A
Doc fix? yes
New docs? yes
Applies to all
Fixed tickets Related to #4668

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please move the method role on its own line?

@snoek09
Copy link
Author

snoek09 commented Jun 2, 2015

@xabbuh done, please let me know if this needs any other changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that this sentence should be worded more "smoothy". Though I'm not sure how. Maybe our native speaker @weaverryan has a suggestion.

@snoek09 snoek09 closed this Oct 13, 2015
@xabbuh
Copy link
Member

xabbuh commented Oct 20, 2015

@snoek09 I am sorry for the delay here. Do you think we should still tackle this and reopen the PR in that case?

@snoek09
Copy link
Author

snoek09 commented Oct 20, 2015

I closed this because it is already merged into 2.6: 85dc294

@xabbuh
Copy link
Member

xabbuh commented Oct 20, 2015

Indeed, but it seems to be missing in the 2.7 version of the docs if I don't miss anything.

@xabbuh
Copy link
Member

xabbuh commented Oct 20, 2015

see #5816

@snoek09
Copy link
Author

snoek09 commented Oct 20, 2015

In that case, just re-use the text and change it where needed.

@xabbuh
Copy link
Member

xabbuh commented Oct 20, 2015

@snoek09 Sorry for poking you again. I had a look at this again and I think we should actually merge this one so that we have a description in the 2.3 docs too. What do you think?

@snoek09
Copy link
Author

snoek09 commented Oct 20, 2015

As I deleted the related fork a while back and closed this PR I can't reopen this.

New PR is here: #5818

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants