Adding information about empty files sent using BinaryFileResponse. #5345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 thanks for adding this help note. Maybe our native English speaker wants to do some minor changes. But apart from that, the note is nice. Thanks! |
| @@ -517,6 +517,14 @@ It is possible to delete the file after the request is sent with the | |||
| :method:`Symfony\\Component\\HttpFoundation\\BinaryFileResponse::deleteFileAfterSend` method. | |||
| Please note that this will not work when the ``X-Sendfile`` header is set. | |||
|
|
|||
| .. note:: | |||
|
|
|||
| If a file is created in the same request as when the ``BinaryFileResponse`` | |||
There was a problem hiding this comment.
in the same request the BinaryFileResponse is sent
|
Thanks @kherge! |
weaverryan
added a commit
that referenced
this pull request
Oct 15, 2015
…ileResponse. (kherge) This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5345). Discussion ---------- Adding information about empty files sent using BinaryFileResponse. Updating documentation to account for weird scenario described in #5268. Commits ------- aa2ac55 Adding information about empty files sent using BinaryFileResponse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating documentation to account for weird scenario described in #5268.