Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworded the explanation about the kernel.event_listener tag #5445

Merged
merged 3 commits into from
Dec 23, 2015

Conversation

javiereguiluz
Copy link
Member

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets #4680

This tag allows you to hook your own classes into Symfony's process at different
points.
During the execution of a Symfony application, different events are triggered.
This tag allows you to *hook* your own classes into any of those events.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add something that explains that you can also trigger your own events that will be dispatched through the same service as the core ones.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your proposal but I'm stuck trying to implement it. Do you have some suggestion for the new explanation? Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to use something like this:

During the execution of a Symfony application, different events are triggered and you can also dispatch custom events. This tag allows [...]

@javiereguiluz
Copy link
Member Author

Reworded and rebase. Thanks @xabbuh for your help.

@wouterj
Copy link
Member

wouterj commented Dec 22, 2015

👍

@weaverryan
Copy link
Member

Thanks guys!

@weaverryan weaverryan merged commit edd3875 into symfony:2.3 Dec 23, 2015
weaverryan added a commit that referenced this pull request Dec 23, 2015
…tag (javiereguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Reworded the explanation about the kernel.event_listener tag

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4680

Commits
-------

edd3875 Restored some content deleted by mistake
58d6346 Minor rewording
db7b78f Reworded the explanation about the kernel.event_listener tag
@javiereguiluz javiereguiluz deleted the fix_4680 branch May 24, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants