Removed the glossary #5464
Removed the glossary #5464
Conversation
|
@wouterj I am more concerned about the link to the glossary in the navigation. Would be bad if a link led to a non-existing page. |
|
👍, but only after Javier is able to remove the Glosaary link on http://symfony.com/doc/current/index.html |
|
Ah, missed that link. Indeed, we should wait until the link is removed from the index |
|
ping @javiereguiluz Did you already create a PR to remove the glossary link? |
|
I'm sorry to bother you again, @javiereguiluz, but what is the status of this? |
|
ping @javiereguiluz :) |
|
👍 Ping @javiereguiluz - only this needs to be done here: #5464 (comment) |
|
The glossary has now been unlinked from the Symfony Docs index (it will be public after the next deployment). |
|
Thanks @javiereguiluz! I've rebased this PR, it's ready to merge once symfony.com is redeployed. status: reviewed |
This PR was submitted for the 2.3 branch but it was merged into the 2.7 branch instead (closes symfony#5464). Discussion ---------- Removed the glossary | Q | A | --- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | symfony#5462 It's funny that 99% of the `:term:` usages were located in sentences describing a term. So we didn't loose any information there. In some cases, I've tweaked the sentence a bit not loose any important information. As for the genindex mentioned by @xabbuh in the issue, I believe this one is created automatically by Sphinx based on all `.. index::` directives in the documentation. When removing the glossary, the genindex will automatically not include the terms anymore (/cc @javiereguiluz please confirm). Commits ------- 1c05aad Removed the glossary
|
@wouterj Thank you! |
It's funny that 99% of the
:term:usages were located in sentences describing a term. So we didn't loose any information there. In some cases, I've tweaked the sentence a bit not loose any important information.As for the genindex mentioned by @xabbuh in the issue, I believe this one is created automatically by Sphinx based on all
.. index::directives in the documentation. When removing the glossary, the genindex will automatically not include the terms anymore (/cc @javiereguiluz please confirm).