Added a tip about hashing the result of nextBytes() #5472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javiereguiluz
commented
Jul 2, 2015
javiereguiluz
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | all |
| Fixed tickets | #4328 |
|
This little contribution needs some review. Thanks! |
| The ``nextBytes()`` method returns a binary string which may contain the | ||
| ``\0`` character. If you store this value in a database or include it as | ||
| part of the URL, make sure to hash the value returned by ``nextBytes()`` | ||
| (to do that, you can use a simple ``md5()`` PHP function). |
There was a problem hiding this comment.
Not sure if we should limit the tip to these two scenarios. There could be lots of third-party systems you need so send data to which may or may not be capable of handling strings containing the null byte. Could we/should we write this more generic?
There was a problem hiding this comment.
I agree. I've reworded this tip. Thanks.
|
👍 |
weaverryan
added a commit
that referenced
this pull request
Jul 16, 2015
…viereguiluz) This PR was merged into the 2.3 branch. Discussion ---------- Added a tip about hashing the result of nextBytes() | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | all | Fixed tickets | #4328 Commits ------- 1a4b5fa Reword 64460d5 Added a tip about hashing the result of nextBytes()
weaverryan
added a commit
that referenced
this pull request
Jul 16, 2015
|
Awesome! Minor tweaks at sha: 6a34332 |
weaverryan
added a commit
that referenced
this pull request
Jul 16, 2015
* 2.3: [#5472] Minor tweak and adding code example Reword Fix caching Fix build Added a tip about hashing the result of nextBytes() rework the quick tour's big picture fix for Symfony 2.7 Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7 Improve travis build speed
weaverryan
added a commit
that referenced
this pull request
Jul 16, 2015
* 2.6: [#5472] Minor tweak and adding code example [#5453] Minor tweaks - mostly thanks to Javier Reword Fix caching Fix build Added a tip about hashing the result of nextBytes() rework the quick tour's big picture fix for Symfony 2.7 Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7 Improve travis build speed
weaverryan
added a commit
that referenced
this pull request
Jul 16, 2015
* 2.7: [#5472] Minor tweak and adding code example [#5453] Minor tweaks - mostly thanks to Javier Reword Fix caching Fix build Added a tip about hashing the result of nextBytes() rework the quick tour's big picture fix for Symfony 2.7 Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7 Improve travis build speed
weaverryan
added a commit
that referenced
this pull request
Jul 16, 2015
* 2.8: [#5472] Minor tweak and adding code example [#5453] Minor tweaks - mostly thanks to Javier Reword Fix moving the mapped down as per @xabbuh Fix caching Fix build Fix the rendering issue Fix issues reported by @snoek09 . Thank you. Added a tip about hashing the result of nextBytes() Make the necessary changes mentioned by @xabbuh and add example for form rework the quick tour's big picture fix for Symfony 2.7 Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7 Starting with range documentation Improve travis build speed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.