Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security voters fixes #5496

Merged

Conversation

german-bortoli
Copy link

Fixed PHP doc for how to declare the voter as a service, now they are identical to XML and YAML.

@xabbuh
Copy link
Member

xabbuh commented Jul 6, 2015

👍

@xabbuh
Copy link
Member

xabbuh commented Jul 6, 2015

Thank you for the perfect PR @Germanaz0. As this was your first contribution to the Symfony docs, you will also soon be rewarded the Symfony doc badge on SensioLabs Connect. I hope to see you back soon with more fixes. :)

@xabbuh xabbuh merged commit 390c05f into symfony:2.3 Jul 6, 2015
xabbuh added a commit that referenced this pull request Jul 6, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Security voters fixes

Fixed PHP doc for how to declare the voter as a service, now they are identical to XML and YAML.

Commits
-------

390c05f Fixed PHP doc for how to declare the voter as a service, now they are identical to XML and YAML.
@german-bortoli
Copy link
Author

@xabbuh thanks at you to give your time for review the code and validate the PR.

I will be around ^^

@german-bortoli german-bortoli deleted the hotfix/security/voters_data_permission branch July 7, 2015 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants