Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of supported branches for Platform.sh. #5532

Closed
wants to merge 2 commits into from
Closed

List of supported branches for Platform.sh. #5532

wants to merge 2 commits into from

Conversation

GuGuss
Copy link

@GuGuss GuGuss commented Jul 16, 2015

It seems the configuration has not been added to legacy branches (2.0 => 2.5).

Augustin Delaporte added 2 commits July 16, 2015 17:31
It seems the configuration has not been added to legacy branches (2.0 => 2.5).
``.platform/routes.yaml`` allow `Platform.sh`_ to build Pull Requests.
.. note::
Only the following branches are supported for building Pull Requests: 2.3 (LTS),
2.6, 2.7, 2.8.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just state here that we only maintain the configuration for maintained branches (which correspond to the currently maintained Symfony versions). This way we would save us work when versions reach end of support and so on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for this suggestion

@wouterj
Copy link
Member

wouterj commented Jul 29, 2015

Closing in favor of #5578 , thanks for suggesting to add this, @GuGuss!

@wouterj wouterj closed this Jul 29, 2015
xabbuh added a commit that referenced this pull request Oct 3, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Add supported branches in platform.sh section

Replaces #5532 with a solution that is less likely to get outdated.

| Q | A
| --- | ---
| Doc fix? | yes
| New docs? | yes
| Applies to | all
| Fixed tickets | -

Commits
-------

f33868b Improve Platform.sh mention in contributing docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants