Improve and simplify the contributing instructions about tests #5564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
javiereguiluz
commented
Jul 27, 2015
javiereguiluz
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | - |
| Symfony test suite to check that you have not broken anything. | ||
| The Symfony project uses a third-party service which automatically runs tests | ||
| for any submitted :doc:`patch <patches>`. If the new code breaks any test, | ||
| you'll be notified in detail about that error. |
There was a problem hiding this comment.
you should mention that this will be in the PR status. The contributor will not be notified by email
There was a problem hiding this comment.
I agree with you. That phrase has been reworded. Thanks!
|
👍 |
1 similar comment
|
👍 |
xabbuh
added a commit
that referenced
this pull request
Jul 28, 2015
…tests (javiereguiluz) This PR was squashed before being merged into the 2.3 branch (closes #5564). Discussion ---------- Improve and simplify the contributing instructions about tests | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Commits ------- 5a942f8 Improve and simplify the contributing instructions about tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.