Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7][Form][Entity] Added "translation_domain" and "choice_translation_domain" #5614

Closed
wants to merge 4 commits into from
Closed

Conversation

merorafael
Copy link
Contributor

Added "choice_translation_domain" and "translation_domain" documentation.

Added "choice_translation_domain" and "translation_domain" documentation.
@merorafael merorafael changed the title Update entity.rst [2.7][Form][Entity] Added "translation_domain" and "choice_translation_domain" Aug 10, 2015
Fixed title underline.
@OskarStark
Copy link
Contributor

thank you for your work 👍

@xabbuh
Copy link
Member

xabbuh commented Aug 17, 2015

@merorafael Thank you for opening the pull request. Could you also update the other affected form types?

~~~~~~~~~~~~~~~~~~

.. versionadded:: 2.7
The ``translation_domain`` option was introduced in Symfony 2.7.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is true

@aitboudad
Copy link
Contributor

@merorafael see #5134 for more details

"choice_translation_domain" description fixed.
@merorafael
Copy link
Contributor Author

Sorry guys, I have not had much time these days. :(
@aitboudad I fixed the "choice_translation_domain". The "translation_domain" is correct?

"translation_domain" documentation fixed.
@elfen
Copy link

elfen commented Nov 4, 2015

Up.

@merorafael
Copy link
Contributor Author

@xabbuh, @albabar, @OskarStark... the doc is complete?

@wouterj
Copy link
Member

wouterj commented Feb 6, 2016

Hi @merorafael! I'm very sorry that we, for some reason, kinda ignored this PR. It seems that someone else documented this option in the mean time. Nobody however documented the behaviour of translation_domain in these cases. As I like that description, I've taken your changes, edited them a bit and created a new PR (keeping all credits to you): #6233

Thanks for your contribution!

@wouterj wouterj closed this Feb 6, 2016
xabbuh added a commit that referenced this pull request Feb 10, 2016
…el, WouterJ)

This PR was merged into the 2.7 branch.

Discussion
----------

Document translation_domain for choice fields

It has a slightly different behaviour, I think it's interested to document it.

This finishes #5614.

| Q | A
| --- | ---
| Doc fix? | no
| New docs? | yes
| Applies to | 2.7+
| Fixed tickets | -

Commits
-------

4b92e88 Document translation_domain setting for choice fields
92998d8 translation_domain doc fix
2fa2386 choice_translation_domain doc fix
3ad5111 Travis fix
5957927 Update entity.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants