-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.7][Form][Entity] Added "translation_domain" and "choice_translation_domain" #5614
Conversation
Added "choice_translation_domain" and "translation_domain" documentation.
Fixed title underline.
thank you for your work 👍 |
@merorafael Thank you for opening the pull request. Could you also update the other affected form types? |
~~~~~~~~~~~~~~~~~~ | ||
|
||
.. versionadded:: 2.7 | ||
The ``translation_domain`` option was introduced in Symfony 2.7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is true
@merorafael see #5134 for more details |
"choice_translation_domain" description fixed.
Sorry guys, I have not had much time these days. :( |
"translation_domain" documentation fixed.
Up. |
@xabbuh, @albabar, @OskarStark... the doc is complete? |
Hi @merorafael! I'm very sorry that we, for some reason, kinda ignored this PR. It seems that someone else documented this option in the mean time. Nobody however documented the behaviour of Thanks for your contribution! |
…el, WouterJ) This PR was merged into the 2.7 branch. Discussion ---------- Document translation_domain for choice fields It has a slightly different behaviour, I think it's interested to document it. This finishes #5614. | Q | A | --- | --- | Doc fix? | no | New docs? | yes | Applies to | 2.7+ | Fixed tickets | - Commits ------- 4b92e88 Document translation_domain setting for choice fields 92998d8 translation_domain doc fix 2fa2386 choice_translation_domain doc fix 3ad5111 Travis fix 5957927 Update entity.rst
Added "choice_translation_domain" and "translation_domain" documentation.