Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Body tag to see the web debug toolbar #5617

Merged
merged 1 commit into from
Aug 17, 2015

Conversation

rmed19
Copy link
Contributor

@rmed19 rmed19 commented Aug 10, 2015

Add body tag on the response content to see the web debug toolbar.

Q A
Doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets #5616

@javiereguiluz
Copy link
Member

At first I was divided about this change. It "complicates" the code for no apparent reason (the user will have a real page instead of using the Response() directly).

However, later in the same chapter we tell the reader:

If you refresh now, you'll be logged in! The web debug toolbar even tells you who
you are and what roles you have:

Since the toolbar doesn't show up if you don't have a closing </body> tag, I think this change is the right thing to do. So now I'm 👍

@xabbuh
Copy link
Member

xabbuh commented Aug 17, 2015

👍

@xabbuh
Copy link
Member

xabbuh commented Aug 17, 2015

Thank you Mohammed.

@xabbuh xabbuh merged commit d38e527 into symfony:2.3 Aug 17, 2015
xabbuh added a commit that referenced this pull request Aug 17, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Add Body tag to see the web debug toolbar

Add body tag on the response content to see the web debug toolbar.

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | #5616

Commits
-------

d38e527 Add Body tag to see the web debug toolbar
@rmed19
Copy link
Contributor Author

rmed19 commented Aug 18, 2015

Hi @xabbuh,
this change should be add to all symfony 2.* documentation not only the 2.3.
Should I create a new pull request?

@javiereguiluz
Copy link
Member

@rmed19 don't worry about that. Changes are always merged in the oldest branch and then, from time to time, doc managers merge old branches into newer ones. So in a few hours/days, this change will be merged into 2.7, 2.8 and master.

@xabbuh
Copy link
Member

xabbuh commented Aug 18, 2015

@rmed19 I just merged branches up so your changes are now also available in 2.7, 2.8 and master and they will be visible soon when the documentation is rebuilt. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants