Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tell about SYMFONY__TEMPLATING__HELPER__CODE__FILE_LINK_FORMAT #5625

Merged
merged 1 commit into from
Nov 25, 2015

Conversation

nicolas-grekas
Copy link
Member

Q A
Doc fix? yes
New docs? yes
Applies to all
Fixed tickets -

in the ``php.ini`` configuration to the url string. If this configuration
value is set, then the ``ide`` option will be ignored.
in the ``php.ini`` configuration to the url string.
An other way if you don't use Xdebug is to set this url string in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An other -> Another

value is set, then the ``ide`` option will be ignored.
in the ``php.ini`` configuration to the url string.
An other way if you don't use Xdebug is to set this url string in the
``SYMFONY__TEMPLATING__HELPER__CODE__FILE_LINK_FORMAT`` environement variable.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

environement -> environment

@javiereguiluz
Copy link
Member

👍

A minor comment to our doc managers: in symfony/symfony#15549 there is a pending merge to fix some issue related to the framework.ide option. But this PR can be safely merged without waiting for getting that bugfix merged. Thanks!

in the ``php.ini`` configuration to the url string. If this configuration
value is set, then the ``ide`` option will be ignored.
in the ``php.ini`` configuration to the url string.
Another way if you don't use Xdebug is to set this url string in the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a new paragraph?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should "if you don't use Xdebug" be enclosed by commas?

fabpot added a commit to symfony/symfony that referenced this pull request Aug 23, 2015
…t (nicolas-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

[FrameworkBundle] Fix precedence of xdebug.file_link_format

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | symfony/symfony-docs#5625

See symfony/demo#148 (comment)

Commits
-------

adb5327 [FrameworkBundle] Fix precedence of xdebug.file_link_format
fabpot added a commit to symfony/framework-bundle that referenced this pull request Aug 23, 2015
…t (nicolas-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

[FrameworkBundle] Fix precedence of xdebug.file_link_format

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | symfony/symfony-docs#5625

See symfony/demo#148 (comment)

Commits
-------

adb5327 [FrameworkBundle] Fix precedence of xdebug.file_link_format
@xabbuh
Copy link
Member

xabbuh commented Sep 30, 2015

@nicolas-grekas Can you finish here?

@nicolas-grekas
Copy link
Member Author

updated

@wouterj
Copy link
Member

wouterj commented Nov 25, 2015

👍

@xabbuh
Copy link
Member

xabbuh commented Nov 25, 2015

Thank you @nicolas-grekas.

@xabbuh xabbuh merged commit beef19e into symfony:2.3 Nov 25, 2015
xabbuh added a commit that referenced this pull request Nov 25, 2015
…ORMAT (nicolas-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

Tell about SYMFONY__TEMPLATING__HELPER__CODE__FILE_LINK_FORMAT

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | yes
| Applies to    | all
| Fixed tickets | -

Commits
-------

beef19e Tell about SYMFONY__TEMPLATING__HELPER__CODE__FILE_LINK_FORMAT
@nicolas-grekas nicolas-grekas deleted the source-link-alt branch July 24, 2016 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants