Fix minor problems in book/page_creation.rst #5635
Conversation
fabschurt
commented
Aug 18, 2015
fabschurt
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | >= 2.6 |
| Fixed tickets | N/A |
| the :doc:`form system </book/forms>`, using :doc:`Doctrine </book/doctrine>` | ||
| if you need to query a database and more. in the :doc:`Symfony Book </book/index>`. | ||
| if you need to query a database and more in the :doc:`Symfony Book </book/index>`. |
There was a problem hiding this comment.
Shouldn't we enclose "if you need to query database" with commas?
There was a problem hiding this comment.
I don't think so, it's just a list. However, I find this sentence very hard to read.
There was a problem hiding this comment.
@wouterj Yes, me too. Maybe it would be more readable by putting it like that? :
Then, in the Symfony Book, learn about the service container, the form system,
using Doctrine (if you need to query a database), and more!
There was a problem hiding this comment.
Big 👍 (except that we don't use serial comma's like the one before "and more!")
There was a problem hiding this comment.
Noted 😉 I'm going to modify the PR.
|
👍 |
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #5635). Discussion ---------- Fix minor problems in book/page_creation.rst | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | >= 2.6 | Fixed tickets | N/A Commits ------- 5a4a51b Fix minor problems in book/page_creation.rst
|
Thank you @fabschurt. I have merged your patch into the |
|
Sure, actually I had branched from |
