Update page_creation.rst #5644
Update page_creation.rst #5644
Conversation
jnadaud
commented
Aug 20, 2015
jnadaud
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.7 |
| Fixed tickets |
| Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.7 | Fixed tickets |
|
Thanks for fixing even more occurences of this, Jérôme! I've patched this into the oldest, still maintained, version (which is 2.3 at the moment). |
|
ok, thank you. Next time I will do it on 2.3 branch! Best regards. |
| @@ -137,7 +137,7 @@ You can even shorten this with the handy :class:`Symfony\\Component\\HttpFoundat | |||
| // --> don't forget this new use statement | |||
| use Symfony\Component\HttpFoundation\JsonResponse; | |||
|
|
|||
| class LuckyController | |||
| class LuckyController extends Controller | |||
There was a problem hiding this comment.
well, this example does not depend on any method of the base class. So why extending it ?
There was a problem hiding this comment.
As this article describes how to create one action. So each code example is based on the previous example. It would be very strange to have the extends part in all examples but one.
Also, as this article is focused on beginners, it's confusion when not extending Controller imo.
There was a problem hiding this comment.
@wouterj I'd like to ask you something about this LuckyController. What do you think about renaming it to DefaultController? This code is shown very early in the book and it's linked from the new Symfony Welcome Page, so most of the readers will be newcomers.
