Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Constraint reference with best practices #5645

Merged
merged 1 commit into from
Aug 22, 2015

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Aug 20, 2015

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets -

A quick search & replace to use AppBundle in the constraint docs. After a quick scan, I think we don't have to update anything else in the constraint reference in order to comply with the best practices.

@javiereguiluz
Copy link
Member

👍 nice!

@xabbuh
Copy link
Member

xabbuh commented Aug 22, 2015

👍 Great work, Wouter!

@xabbuh xabbuh merged commit fe7aa8b into symfony:2.3 Aug 22, 2015
xabbuh added a commit that referenced this pull request Aug 22, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Updated Constraint reference with best practices

| Q | A
| --- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | all
| Fixed tickets | -

A quick search & replace to use AppBundle in the constraint docs. After a quick scan, I think we don't have to update anything else in the constraint reference in order to comply with the best practices.

Commits
-------

fe7aa8b Updated Constraint reference with best practices
@wouterj wouterj deleted the best_practices_reference branch September 5, 2015 09:34
wouterj added a commit that referenced this pull request Sep 5, 2015
…straints reference (xabbuh)

This PR was merged into the 2.7 branch.

Discussion
----------

[Reference][Constraints] follow best practices in the constraints reference

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.7+
| Fixed tickets |

This completes the work done by @wouterj in #5645 by updating the docs that were added for Symfony 2.6/2.7.

Commits
-------

bfca2b7 follow best practices in the constraints reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants