-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc about new way of running tests #5654
Conversation
@@ -35,7 +34,7 @@ command: | |||
|
|||
.. code-block:: bash | |||
|
|||
$ phpunit | |||
$ php ./phpunit symfony |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this correct?
my binary is located under bin/phpunit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it is: we don't want your phpunit, we want symfony's one (see linked PR)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR was merged into the 2.3 branch. Discussion ---------- Add appveyor.yml for C.I. on Windows | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | YES, both on Travis (Linux) and on Appveyor (Windows)! | Fixed tickets | #13934, #15049, #14259, #15045, #15444 | License | MIT | Doc PR | symfony/symfony-docs#5654 - testing two matrix lines: - one without mbtring nor fileinfo nor intl - one with these ext enables, intl version 51.2 so that almost no test is skipped on our Intl component - bug fixes thanks to these harder testing conditions - some display bug on appveyor, [reported here](http://help.appveyor.com/discussions/suggestions/197-support-ansi-color-codes). Commits ------- ea5d656 Windows and Intl fixes 8bbd8d9 Add appveyor.yml for C.I. on Windows
👍 let's see if these changes are merged soon. |
|
||
.. code-block:: bash | ||
|
||
$ composer install | ||
$ composer update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need update
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but have the same result, as the project doesn't have a lock file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When one works on a patch and a composer file is changed, only update works, that's why it's more generic
👍 |
Thank you @nicolas-grekas. |
This PR was merged into the 2.3 branch. Discussion ---------- Doc about new way of running tests | Q | A | ------------- | --- | Doc fix? | yes | New docs? | yes | Applies to | all | Fixed tickets | - Related to symfony/symfony#15575 Commits ------- dc754c8 Doc about new way of running tests
Related to symfony/symfony#15575