Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update routing.rst #5659

Closed
wants to merge 1 commit into from
Closed

Update routing.rst #5659

wants to merge 1 commit into from

Conversation

ycklsr
Copy link

@ycklsr ycklsr commented Aug 26, 2015

The example code wasn't matching the proposed use-case, i.e establish a strict distinction between GET and POST requests for the very same route.

The example code wasn't matching the proposed use-case, i.e establish a strict distinction between GET and POST requests for the very same route.
@xabbuh
Copy link
Member

xabbuh commented Aug 26, 2015

Thanks for noticing this issue and providing a PR @Gwad. Actually, we are discussing this issue in #5583. Maybe you want to comment their too with your opinion.

@wouterj
Copy link
Member

wouterj commented Dec 21, 2015

Hi @Gwad. Thank you for trying to fix & improve the docs and participating in the discussion!

Unfortunately, I'm going to close this PR in favor of #6062 , which rewrites this section to use an API (APIs are already introduced earlier in the Book). 🎄

@wouterj wouterj closed this Dec 21, 2015
xabbuh added a commit that referenced this pull request Jan 11, 2016
This PR was merged into the 2.3 branch.

Discussion
----------

Update HTTP method requirement example

| Q | A
| --- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | 2.3+
| Fixed tickets | #5583

After many reports (#5779, #5659) of the text no longer matching the example, I think it's time to update the example.

The example now uses an API, which is a very common thing now and often needs this feature. API's are already used in the Page Creation article, which is placed before this article, so it shouldn't be too hard to understand.

I know that from a REST prespective, HEAD and GET using the same action doesn't seem that great, but it's the only action I could think of that may support 2 methods.

Commits
-------

30c2750 Update method requirement example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants