Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update storage.rst #5681

Closed
wants to merge 2 commits into from
Closed

Update storage.rst #5681

wants to merge 2 commits into from

Conversation

jls2933
Copy link
Contributor

@jls2933 jls2933 commented Sep 9, 2015

No description provided.

javiereguiluz
javiereguiluz reviewed Sep 9, 2015
View reviewed changes
cookbook/profiler/storage.rst
@@ -4,7 +4,7 @@
Switching the Profiler Storage
==============================

By default the profile stores the collected data in files in the cache directory.
By default the profile stores the collected data in files in the cache directory, under ``%kernel.cache_dir%/profiler``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to add the explicit location, but what about rewording it a bit:

By default the profile stores the collected data in files in the ``%kernel.cache_dir%/profiler/`` directory.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this proposal.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for @javiereguiluz' proposal.

@jls2933 can you please edit your PR to use this rewording? If you don't have the time or you don't know how to do it, feel free to ask for help or we can do it after merging the PR.

@xabbuh
Copy link
Member

xabbuh commented Oct 20, 2015

👍

@weaverryan
Copy link
Member

I like it - thanks @jls2933!

@weaverryan weaverryan closed this Nov 5, 2015
weaverryan added a commit that referenced this pull request Nov 5, 2015
@weaverryan
minor #5681 Update storage.rst (jls2933)
054e9e0 
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5681).

Discussion
----------

Update storage.rst

Commits
-------

1028d5f Rewriting of the sentence.
c69b277 Update storage.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jls2933 @xabbuh @weaverryan @javiereguiluz @wouterj